search

TA2k / ioBroker.vw-connect

ioBroker Adapter for VW We connect and Skoda connect
MIT License
90 stars 22 forks source link

FIX: empty body causes VWV2 to break #202

Closed martijnpoppen closed 2 years ago

martijnpoppen commented 2 years ago

When the body is an empty string the API call fails for VWV2 cars.

Making this body conditional based on the length does work.

TA2k commented 2 years ago

Thanks for the PR. But I would not recommended to this project as a dependency because the code and the structure is really crap. Because of missing test and accounts for the 10 different client implementation the code is not refactorable.

martijnpoppen commented 2 years ago

Thanks. Yes using the ioBroker plugin and I tried some project for myself. Then I saw the issue.

TA2k commented 2 years ago

Ok but sorry for the code

martijnpoppen commented 2 years ago

No worries. Best solution out here :) So great effort!

Maybe I'll make a new PR when I find something ;)