search

TACC-Cloud / tapis-cli

Next-generation Tapis CLI
BSD 3-Clause "New" or "Revised" License
14 stars 5 forks source link

tapis apps deploy fails with 404 for new Designsafe accounts. #360

Open bpachev opened 3 years ago

bpachev commented 3 years ago

Describe the bug Under certain conditions (typically new users deploying their first application), tapis apps deploy fails with a 404 unless --no-upload is specified.

To Reproduce Steps to reproduce the behavior:

  1. Create a new DesignSafe Account (or temporarily rename the apps directory)
  2. Run tapis auth init --interactive and choose designsafe
  3. Clone https://github.com/cdelcastillo21/tapisv2_apps and cd tapisv2_apps/test_app
  4. tapis apps deploy

Expected behavior A message similar to the one below [Errno 404] Not Found for https://agave.designsafe-ci.org/files/v2/media/system/designsafe.storage.default//bpachev/apps/assets-2021-06-07: 'No such file or directory'

After some time digging around the source code, I discovered the issue was because I didn't have an apps directory on my DesignSafe account - and the code did not handle the case when multiple directories on deployPath don't exist. I created a simple, minimal PR that resolved the issue I ran into - https://github.com/TACC-Cloud/tapis-cli/pull/359.