feat(apcd-cms): core-cms v3.11.0 candidate

wesleyboar commented 1 year ago

Status

Overview

Change APCD CMS to rely on upcoming Core-CMS v3.11 code instead of TACC/Core-CMS#567.*

^{* TACC/Core-CMS#567 was v3.9 + 25 commits of v3.10.}

Finally brings belated Core-Styles to APCD.
Tests v3.11 on the CMS most cumbersome to upgrade.
Removes cruft and duplicate CSS.

Changes

UI

new table styles
fixed link hover state (border was dashed and too close to text)
new accent color (purple, matches portal)

Code

changed core cms image
added load of new apcd table and modal stylesheets
removed load of unused form stylesheets (now available from core)
removed stylesheets, or code from stylesheets, whose code is now in apcd table and modal stylesheets
- per-page css is retained in per-page stylesheets
changed pagination to load from core-styles v0.13 (instead of v0.10)
added conflicts-with-core css files to deal with apcd still being both a bit ahead and behind core
removed most table desktop styles

Testing

Deployed to https://apcd-qa.tacc.utexas.edu/ on 2023-05-21.

Compare all pages to pre-prod before deploy of new CMS version.

UI

Register

Submissions

| | before | after | | - | - | - | | List Submissions | ![submissions_list-submissions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/651ebdd3-a42f-460a-83b0-c19fd75eb237) | ![submissions_list-submissions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/a94bbe6c-9515-4f07-a1bb-a38a6e06c0a3) | | Request Exception | ![submissions_exception_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/3a99ecf2-5e11-4da0-81f7-2829fc410b48) | ![submissions_exception_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/b44cf716-e26d-4303-8a1b-feec1cdd9344) | | Request Exception Form | ![OLD submissions_threshold-exception_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/2a1c0b09-78e7-4ff2-8a23-fa7d368f2e1c) | ![NEW submissions_threshold-exception_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/49724d85-843a-43ec-9bab-5cf6873646a6) | | Request Extension | ![submissions_extension-request_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/a2fc816a-7a85-448f-9a1c-08e6a651a40a) | ![submissions_extension-request_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/d28fae5a-bdad-4cda-970b-43bdba86ffa0) | | Request Extension Form | ![OLD submissions_extension-request_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/aa2098cd-a923-465e-a389-4a0259899139) | ![NEW submissions_extension-request_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/0a9208da-5f1f-44b2-983f-34925a74f0f8) |

Administration

| | before | after | | - | - | - | | List Submissions | ![administration_list-submissions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/57ef1e1b-a0ec-4e3c-939b-a7723936305f) | ![administration_list-submissions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/e2cb9894-47e6-4611-9d5f-02313d0597c8) | | List Extension Requests | ![administration_list-extensions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/83d0e126-435b-49b4-9d7c-59dd090f506b) | ![administration_list-extensions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/b9448012-985e-4af2-be6f-6482dd769437) | | List Exception Requests | ![administration_list-exceptions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/1a16acf1-5abd-4164-b7fe-f11e3742bf71) | ![administration_list-exceptions_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/f71c2eb5-736f-4842-9887-090cfce9cd09) | | List Users | ![administration_view-users](https://github.com/TACC/Core-CMS-Custom/assets/62723358/c38688fd-7c5f-4928-b99a-6297c74a29a7) | ![administration_view-users_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/2d265098-6e44-4c4c-82e2-5fcf3edfafab) | | List Registrations | ![administration_list-registration-requests_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/bf1d3ef7-de41-4d29-b308-104c3fc94d4f) | ![administration_list-registration-requests_](https://github.com/TACC/Core-CMS-Custom/assets/62723358/cba1de01-6e38-4237-bbcc-d8694cf86e21) |

Help

Notes

Known Issues

https://apcd-qa.tacc.utexas.edu/submissions/exception/ buttons do not have hover state.
- Pre-existing bug.
- Caused by APCD markup not using c-button c-button--primary.
Font that is regular weight and italic style is too thick.
- Pre-existing bug which now occurs in modal forms (because styling is now consistent).
- See TACC/Core-CMS#638 "Known Issues" № 6.
Accent color has changed from blue to purple.
- Not a bug.
- See TACC/Core-CMS#638 "Known Issues" № 3.
Pagination styles are wrong on Review Extensions and Review Exceptions pages.
- Pre-existing bug.
- Reported in WP-150.

wesleyboar commented 1 year ago

Cool!

I found some things I may do before I merge:

test https://apcd-qa.tacc.utexas.edu/submissions/threshold-exception/ [^1]
test https://apcd-qa.tacc.utexas.edu/submissions/extension-request/ [^1]
maybe change purple back to blue (for Core-CMS v3.11)

[^1]: Requires I be in the database.

wesleyboar commented 1 year ago

Final tasks complete:

I tested https://apcd-qa.tacc.utexas.edu/submissions/threshold-exception/.
I tested https://apcd-qa.tacc.utexas.edu/submissions/extension-request/.
Only accent color differs. Fix can come in https://github.com/TACC/Core-CMS/releases/tag/v3.11.0-beta.3.
This PR is not coupled to https://github.com/TACC/Core-CMS-Custom/pull/141. That PR can wait.

I merge.

TACC / Core-CMS-Custom