TACC / Core-CMS-Custom

Customized Core CMS code and builds
5 stars 0 forks source link

hotfix: set SESSION_COOKIE_SECURE = True #197

Closed wesleyboar closed 1 year ago

wesleyboar commented 1 year ago

Overview

Hotfix setting SESSION_COOKIE_SECURE = True.

Warning Unable to test on an environment that mirrors production.

Important Target branch (which I created yesterday) https://github.com/TACC/Core-CMS-Custom/tree/release/apcd-prod-2022-11 is off 3a439ba.[^1]

Note Target branch changed after merge to essentially be release/apcd-prod-2022-11-plus-secure-cookie-hotfix. Details.

Related

Changes

Testing

Target Branch

Confirm 3a439ba is the most recently deployed taccwma/apcd-cms tag.[^1]

Portal Login Cookie

  1. In Chrome/ium DevTools > Application > Cookies
  2. Confirm "Secure" column for "sessionid" cookie is checked.

Any CMS Page

Confirm style on CMS pages is unchanged from https://txapcd.org/.

UI

Skipped.

[^1]: I think 3a439ba is the most recently deployed taccwma/apcd-cms tag. Reference.

wesleyboar commented 1 year ago

I did poorly naming branches.

So, after merge:

  1. I created branch release/apcd-prod-2022-11-plus-secure-cookie-hotfix from the merge commit.
  2. I deleted branch release/apcd-prod-2022-11.
  3. I re-created branch release/apcd-prod-2022-11 off of 3a439ba.

Thus, release/apcd-prod-2022-11-plus-secure-cookie-hotfix is what to deploy.

After this, we need to consider release strategy for CMS apps in this repo.