TACC / Core-CMS-Custom

Customized Core CMS code and builds
5 stars 0 forks source link

Task/wp 284 submitter listing table #232

Closed sophia-massie closed 10 months ago

sophia-massie commented 10 months ago

Overview

The goal of this task is to create a new submitter_renewal_listing app to show a listing of all registrations for a submitter. The app:

Related

Changes

  1. Changed function name to get_submitter_info(user) so that multiple apps can use it and it be clear what the function does
  2. Changed the get_registrations, get_registration_entities, and get_registration_contacts so that if a submitter_id is passed to the function, it will join the the submitter table with the registration and get all registration ids with a the matching submitter code.

Testing

  1. Change APCD DB to prod credentials - test DB does not have year as a column on the registrations table yet. Joe is working on this
  2. Go to http://localhost:8000/register/list-registration-requests/
  3. Ensure the page looks like the screen shot. It doesn't look like TACCTEST submitter code has any associated entities or contacts.
  4. Double check that http://localhost:8000/administration/list-registration-requests/ is working as it previously was.

UI

Screenshot 2023-10-25 at 12 40 34 PM

mjames-uth commented 10 months ago

I agreed on a comment a Garrett left, otherwise, looks good

sophia-massie commented 10 months ago

I agreed on a comment a Garrett left, otherwise, looks good


...
if (selectedOption == "renewRegistration") { var xhr;
xhr = new XMLHttpRequest();
xhr.open('GET', `/register/request-to-submit/${reg_id}`)
xhr.send()
window.location.href = `/register/request-to-submit/${reg_id}`;
window.location.load();
}```
Since the submitter form PR is merged, I didn’t disable the renew option because the script above should just work when it’s merged with your PR. Is it ok if I leave it enabled so there won’t have to be another PR to enable it @mjames-uth 
sophia-massie commented 10 months ago

New testing step

In secrets, use prod DB credentials. Testdb has not been updated to include a year column yet.