TACC / Core-CMS-Custom

Customized Core CMS code and builds
5 stars 0 forks source link

Task/wp 338 339 apcd fix dates except exten #237

Closed sophia-massie closed 9 months ago

sophia-massie commented 10 months ago

Overview

Exception WP-339

Extension WP-338

  1. Requested target date should not be allowed to select beyond a year because extensions cannot be granted for periods longer than one year
  2. Current expected due date This should be auto populated from the submitter_calendar based on the data period the user chooses
  3. The data period should be a calendar field that the submitter can select from. Note: The day is not needed as adjudicated claims data is identified by month and year.

Related

WP-339 WP-338

Changes

Exception threshold form:

Extension form:

apcd_database.py:

Testing

Extensions

  1. Go to http://localhost:8000/submissions/extension-request/
  2. Fill out form
  3. When you get to applicable data period, make sure the current expected date populates from a get request once you select something from the auto populated drop down. Add extensions and make sure these fields work after using the add extension button
  4. Make sure the requested target date further out from a year can not be selected
  5. Check that you can submit the form and check that the post request includes the current_expected_date for each extension you submitted.
  6. Go to http://localhost:8000/administration/list-extensions/ and make sure your recently submitted extension is in the list

Exceptions

  1. Go to http://localhost:8000/submissions/threshold-exception/
  2. Check that expiration typo is fixed
  3. Fill out form
  4. Make sure that you can't select an expiration date further out from a year
  5. Add exceptions and make sure you can't select exceptions out further than a year from today in additional exception blocks
  6. Check that you can successfully submit form.
  7. Go to http://localhost:8000/submissions/other-exception/
  8. Make sure that you can't select an expiration date further out from a year
  9. Check that you can successfully submit form.

UI

Extension:

Screenshot 2023-10-31 at 3 41 17 PM

Other Exception - notice how you cannot select dates further from a year from today

Screenshot 2023-10-31 at 3 51 39 PM

Threshold Exception Screenshot 2023-10-31 at 3 57 28 PM

sophia-massie commented 9 months ago

Exceptions are working well. On the extension form, I saw that add. extensions' 'current requested date' did not show up in the POST request on submission.

Good catch! Updated in the latest commit https://github.com/TACC/Core-CMS-Custom/pull/237/commits/e11b891d40921a243d165b5dc7472edddb91cf87