TACC / Core-CMS-Custom

Customized Core CMS code and builds
5 stars 0 forks source link

hotfix: outdated purple accent, pages w/ c-message #256

Closed wesleyboar closed 7 months ago

wesleyboar commented 7 months ago

Overview

Override outdated colors that are overriding Core-CMS fix for those outdated colors.

Related

Uncertain.

Changes

Testing

  1. Open https://localhost:8000/register/request-to-submit/.
  2. Verify accent color is blue (not purple).

UI

before after
before after

Notes

Wait, what's happening? Who was overriding who's what? ℹ️ Register page loads `c-message.css` directly from Core-Styles at v0.13.0. ✅ Home page loads colors from Core-CMS `site.css` which has new/fixed colors. ❌ That old version of `c-message.css` bundles colors within it, thus pages use old colors. ⚠️ The `c-message.css` colors were overriding Core-CMS `site.css`. | page **sans** error | page **with** error | | - | - | | ![home page](https://github.com/TACC/Core-CMS-Custom/assets/62723358/72ddab80-d8e5-4df5-b8d6-cec1f9d4c06c) | ![register page](https://github.com/TACC/Core-CMS-Custom/assets/62723358/4b3cbd34-9ae8-4a3c-b64a-fcc9ac9eb5fd) | _So…_ 💡 I loaded Core-Styles v2 `color.css` to override `c-message.css`. _I could have changed to load `c-message.css` from Core-Styles v2, but then I need to test messages. I'm fixing the specific problem — colors — quickly instead._ 📝 The real fix is updating APCD-CMS to Core-Styles v2 via setting, and testing.