search

TACC / Core-CMS-Resources

Files specific to each website built via TACC/Core-CMS.
3 stars 0 forks source link

fix: do not show breadcrumbs since Core-CMS#870 #201

Closed wesleyboar closed 3 weeks ago

wesleyboar commented 3 weeks ago

Overview / Related

Explicitly do not show breadcrumbs since https://github.com/TACC/Core-CMS/pull/870.

Changes

Notes

Reasoning In Core-CMS, breadcrumbs become their own block. Until now, `fullwidth.html` templates of a custom CMS have implicitly had no breadcrumbs. To continue to **not** show breadcrumbs, these templates must: - **either** explicitly hide breadcrumbs - **or** extend Core-CMS `fullwidth.html` I am more comfortable performing the former without testing. The latter is more appropriate but requires testing (which requires many steps and documenting) and would be moot if I can migrate the CMS's to Core-CMS-Custom ([WP-197](https://tacc-main.atlassian.net/browse/WP-197)) without a custom template (as I have done for some migrated CMS's).
wesleyboar commented 3 weeks ago

Safe to merge before related Core-CMS PR, because this would just create new empty block.