search

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.
https://cep.tacc.utexas.edu
2 stars 1 forks source link

fix: CMS c-button--as-link has button padding #785

Closed wesleyboar closed 7 months ago

wesleyboar commented 7 months ago

Overview

Update Core-Styles to remove padding from a c-button--as-link on CMS.

Related

Changes

Testing

  1. Install TACC/Core-Styles#298 into a CMS.
  2. Create/Edit a page.
  3. Add Text plugin instance with Source code for three types of buttons: 
    <p><button class="c-button c-button--primary">Button</button></p>
<p><button class="c-button c-button--as-link">Button as a Link</button></p>
<p><a class="c-button c-button--primary" href="#">Link as a Button</a></p>
  4. Verify "Button" looks like a primary button using a <button>.
  5. Verify "Button as a Link" looks like a link using a <button>.
  6. Verify "Link as a Button" looks like a primary button using a <a>.

UI

Before After
before after

Before

https://github.com/TACC/Core-CMS/assets/62723358/3a3565a8-fde8-4d67-9e2f-9c5293b93350

After

https://github.com/TACC/Core-CMS/assets/62723358/5885913c-9090-4372-98d8-051d404145a4