Closed wesleyboar closed 1 month ago
PORTAL_MANAGES_AUTH
works for me, it has the PORTAL_
prefix and explicitly states what it does.
PORTAL_IS_CORE
feels too ambiguous imo. Question: What property/aspect of a portal configuration is this supposed to be indicating if not that the AUTH source is the django container?
Aside: I do so which we had called Core-Portal
something less overloaded (Core-Workbench
, Core-Dashboard
, Core-Django
, Core-Workspace
, literally anything else that would not conflate the use of portal
), but it is what it is now...
I changed PORTAL_IS_CORE
to PORTAL_IS_TACC_CORE_PORTAL
.
Perhaps we revisit PORTAL_MANAGES_AUTH
as a setting if we make CMS support LDAP.
I tested this on every [Camino-deployed] Core-CMS website —
— and the only bug was because of upgrading ECEP to v4.9+.
[!IMPORTANT] Merging based on approval of https://github.com/TACC/Core-Portal-Deployments/pull/43.
Overview
Reword
TACC_
settings asPORTAL_
settings.Because (A) Core-CMS is used by clients, so "TACC_LOGO" is a weird setting (because they have their own logo) and (B) The CMS and Portal are aspects of a website that is called Portal in TACC-speak (and I am done grumbling against it).
Status
Related
837
Changes
Testing & UI
https://github.com/TACC/Core-Portal-Deployments/pull/43