search

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.
https://cep.tacc.utexas.edu
2 stars 1 forks source link

Quick: Update Makefile to support git branches #801

Closed rstijerina closed 5 months ago

rstijerina commented 5 months ago

Overview

This PR adds a new variable to the Makefile context: DOCKER_IMAGE_BRANCH

This variable will correspond to the git tag for the commit if it exists, else the branch name for the commit, with special characters replaced with -.

rstijerina commented 5 months ago

Questions

  1. How can I test this awesome?
  2. Is it already used on a another repo successfully?
  3. If so, does it's Jenkins build have code I can copy that will output the tag instead of the commit hash?

My thoughts on № 1 (testing):

  1. I tag the latest commit of this branch.
  2. I run a Jenkins build using the tag.
  3. I check DockerHub for image.
  4. I test deploy some guinea pig CMS.
  1. Yes, perfect testing steps.
  2. Yes, Core-Portal
  3. Jenkins build requires no edits. It will output both the tag and commit hash