hotfix: setTargetForExternalLinks missing scopeElement - Githubissues

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.

https://cep.tacc.utexas.edu

2 stars 1 forks source link

hotfix: setTargetForExternalLinks missing scopeElement #808

Closed wesleyboar closed 4 months ago

wesleyboar commented 4 months ago

Overview

Fix error with setTargetForExternalLinks.js change from #805

Uncaught ReferenceError: scopeElement is not defined at findLinksAndSetTargets (setTargetForExternalLinks.js:11:17) at software-list/:928:3

Related

fixes #805

Changes

replaced scopeElement with document

Testing

Copy edited script to https://github.com/TACC/tup-ui clone at /apps/tup-cms/src/taccsite_cms/static/site_cms/js/modules/setTargetForExternalLinks.js.
On TUP-UI clone, ran npx nx build tup-cms.
On TUP-UI clone, ran npx nx serve tup-cms.
On TUP-UI clone, ran docker exec -it tup_cms sh -c "python manage.py collectstatic --no-input --clear --ignore assets/*/font*.css".

UI

before	after