hotfix: TUP-714 news list page links not working - Githubissues

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.

https://cep.tacc.utexas.edu

2 stars 1 forks source link

hotfix: TUP-714 news list page links not working #830

Closed wesleyboar closed 6 months ago

wesleyboar commented 6 months ago

Overview

Use link.getAttribute('href') not link.href, so isAbsolute is not true for News list "Previous" and "Next" links.

[!WARNING] There is still the problem of the code link.href = link.pathname; which would remove URL parameters, but at least the "Previous" and "next" links are being properly ignored now.

Related

TUP-714
required by https://github.com/TACC/tup-ui/pull/451

Changes

changed link.getAttribute('href') not link.href in setTargetForExternalLinks.js

Testing

Use the new file on a news page with pagination.
- A. Load a page with News on which you've added enough articles. ^{To create less articles, set pagination threshold to be very small.}
- B. Edit same file on tup_cms container directly while running https://github.com/TACC/tup-ui.
Verify "Previous" or "Next" links work.

UI

Script	Page

https://github.com/TACC/Core-CMS/assets/62723358/7aa3c93a-09f3-48a4-82de-da68d3ad97b1