search

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.
https://cep.tacc.utexas.edu
2 stars 1 forks source link

Remove Support for Old Setting Names #842

Open wesleyboar opened 3 months ago

wesleyboar commented 3 months ago

Complaint

Too much code for old setting names that are not used anymore.

Proposal

Remove the code for old setting names.

Alternative

Ignore unused code.

Proof

In TACC/Core-Portal-Deployments@30a41f6, the old setting names are not used:

SEARCH_ TACC_ INCLUDES FAVICON
SEARCH_ TACC_ INCLUDES_ FAVICON
replaced by PORTAL_SEARCH_ only active settings are present replaced by PORTAL_IS_/PORTAL_HAS_ replaced by PORTAL_FAVICON
wesleyboar commented 3 months ago

Technically, removing backwards-compatibility is a breaking change (i.e. an incompatible API change), so I suggest doing this only for v5 release. The v5 release would likely come when Core-CMS uses Django v5.