search

TACC / Core-CMS

The Core CMS codebase used by TACC Portals.
https://cep.tacc.utexas.edu
2 stars 1 forks source link

fix: WP-602 `docker compose` with and without dash #858

Closed wesleyboar closed 2 months ago

wesleyboar commented 2 months ago

Overview

Docker v2 has different command for docker compose. Adjust Makefile to handle both based on availability.

Related

Changes

Testing

  1. make build — no error firing command from Makefile
  2. make start — no error firing command from Makefile

UI

Skipped.

wesleyboar commented 2 months ago

Still open to review. I'll propagate improvements that arise.

wesleyboar commented 2 months ago

We discussed hard-coding docker compose. The old command (docker-compose) has been deprecated for years, but I'm tempted to keep Core-CMS backwards-compatible until v5.

Hard-coding the new command would be a backwards-incompatible change for Core-*, thus technically forcing a Core-CMS v5. There was unofficial agreement to tie Core-CMS major versions to Django v5. I'll add a comment to flag `docker-compose` support as deprecated. _P.S. Example: All the settings changes have been backwards-compatible ([`settings.py`](https://github.com/TACC/Core-CMS/blob/v4.13.1/taccsite_cms/settings.py#L753-L757), [`upgrade-project.py`](https://github.com/TACC/Core-CMS/blob/v4.13.1/docs/upgrade-project.md))._