fix: DES-2724 app-card__type mis-aligned - Githubissues

TACC / Core-Styles

CSS dist files, source code, and build process for TACC-branded projects.

https://tacc.utexas.edu/static/ui

0 stars 0 forks source link

fix: DES-2724 app-card__type mis-aligned #326

Closed wesleyboar closed 5 months ago

wesleyboar commented 5 months ago

Overview

Fix mis-aligned "Types" block on an app card.

The mis-alignment is not always present, but once I could reproduce it, this made sense to fix it.

Status

Closed. See https://github.com/TACC/Core-Styles/pull/326#issuecomment-2027560324.

Related

found while testing DES-2724

Changes

changed margin bottom on card __types box to a static value

Testing

Visit https://www.designsafe-ci.org/testing-pages/image-plugin-email-link/.
Verify gray boxes still line up.
Remove font size of text in gray box*:
1. find c-app-card__type styles
2. disable font-size: 1.2rem
Verify gray boxes still line up.

^{* There may be other ways to product the bug. This worked for me.}

UI

	Bug is apparent	Bug not apparent
Before
After	…

wesleyboar commented 5 months ago

[!IMPORTANT] This "fix" is not following the design. The design vertically centers the gray box in available space, then seems to have placed text so that the boxes also vertically align with each other. The latter seems unfeasible to achieve.