TACC / Core-Styles

CSS dist files, source code, and build process for TACC-branded projects.
https://tacc.utexas.edu/static/ui
0 stars 0 forks source link

Image Card as a Link Breaks Image Layout #411

Open wesleyboar opened 3 weeks ago

wesleyboar commented 3 weeks ago

Overview

Layout of image card ([class*="card--image"]) changes if image is a link.

Steps

  <article class="c-card c-card--plain c-card--image-top">
    <h3>Card - Image top</h3>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. In venenatis odio elit, faucibus blandit tellus mollis ut. Donec vel nibh at nisl fermentum sodales nec quis risus. Nullam et magna in metus vulputate fermentum a a augue.</p>
-   <img src="…">
+   <a href="…">
+     <img src="…">
+   </a>
  </article>

Expected

Actual

Core-Styles

Before After
styles before styles after

Core-CMS

Before Change After
no change what cms user changes change breaks layout
wesleyboar commented 1 week ago

fixed by #419

wesleyboar commented 1 week ago

Reopened, because https://github.com/TACC/tup-ui/pull/487 reveals bugs.

[!WARNING]

  1. Crop of image can change.
  2. Outline might be cropped.