search

TACC / Lmod

Lmod: An Environment Module System based on Lua, Reads TCL Modules, Supports a Software Hierarchy
http://lmod.readthedocs.org
Other
475 stars 122 forks source link

reportMissingDepModules is not using LmodWarning #622

Closed boegel closed 1 year ago

boegel commented 1 year ago

reportMissingDepModules uses io.stderr:write instead of LmodWarning, see https://github.com/TACC/Lmod/blob/768e9410dae778a89e345e21c3a28046cae0a741/src/MainControl.lua#L933

This prevents customizing the error message via errWarnMsgHook.

Is that deliberate for some reason?

rtmclay commented 1 year ago

No, it was a mistake. I have updated Lmod to now use LmodWarning() instead. Please test Lmod 8.7.19 to see if it works for you.

boegel commented 1 year ago

@rtmclay There's no 8.7.19 tag yet?

rtmclay commented 1 year ago

It is there now.

rtmclay commented 1 year ago

can I close this issue?

boegel commented 1 year ago

Yes, thanks!