search

TACC / launcher

A simple utility for executing multiple sequential or multi-threaded applications in a single multi-node batch job
MIT License
63 stars 33 forks source link

bash syntax adjustments related to issue #44 #45

Closed jklynch closed 6 years ago

jklynch commented 6 years ago

This pull request demonstrates changes we made to resolve issue #44.

lwilson commented 6 years ago

I've created a new branch PR45 so that I can test this out. [[ is not technically as portable as [ so I want to make sure that there are no residual issues. Also, since many of the comparisons are already quoted strings, the [[ may not be necessary.

The original error in #44 appears to be related to line 82: if [ $LAUNCHER_JID -gt $LAUNCHER_NJOBS ]. I think there must be an issue with $LAUNCHER_JID not being set. In this case the [[ will likely solve the problem.

I will take a look and merge this branch back into master if I don't encounter any issues.

Thanks @jklynch for pointing this out and providing the potential solution!