Exclude GNU Screen environmental variables in pass_env

TACC / launcher

A simple utility for executing multiple sequential or multi-threaded applications in a single multi-node batch job

MIT License

63 stars 32 forks source link

Exclude GNU Screen environmental variables in pass_env #66

Open AJVincelli opened 3 years ago

AJVincelli commented 3 years ago

Exclude ")" from the environment, which causes Launcher to fail when using GNU Screen on some clusters. Excluding the ")" fixes the issue for me.

AJVincelli commented 3 years ago

@siliu-tacc @lwilson I have never done a Pull Request before, I apologize if I haven't done it right. Basically, when I use GNU Screen on some clusters, one of Screen's environmental variables includes a ")" and causes Launcher to fail. (I mentioned this behavior in Issue #63.) I just added -e ")" to the pass_env file, and this fixes the issue for me. Hopefully it's a tiny fix for review! Thanks!

AJVincelli commented 3 years ago

Hm, actually my fix above might not work in all cases... Hold on while I check into this...

AJVincelli commented 3 years ago

@siliu-tacc @lwilson I updated the fix to include all TERMCAP environment variables, which apparently can include an entire database of tabbed variables. Excluding all tabbed variables seems to clear all (and only) screen variables, and Launcher runs successfully. Maybe somebody else who experiences the error can try this fix to confirm that it works for them too?