search

TACC / pvOSPRay

Other
9 stars 4 forks source link

Ospray 0.9 #33

Closed GregAbram closed 8 years ago

GregAbram commented 8 years ago

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

carsonbrownlee commented 8 years ago

Thanks Greg, will test it on my end. Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram notifications@github.com wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

https://github.com/TACC/pvOSPRay/pull/33

Commit Summary

changes for ospray-0.9 CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs removed Glyph3DRepresentation use alignedFree rather than delete[] back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator File Changes

M CMake/FindOSPRay.cmake (118) M ParaView/CMakeLists.txt (2) M ParaView/OSPRayView.xml (10) M VTK/CMakeLists.txt (8) M VTK/vtkOSPRayCamera.cxx (2) M VTK/vtkOSPRayLight.cxx (1) M VTK/vtkOSPRayPolyDataMapper.cxx (127) M VTK/vtkOSPRayProperty.cxx (7) M VTK/vtkOSPRayRenderable.h (9) M VTK/vtkOSPRayRenderer.cxx (27) M VTK/vtkOSPRayTexture.cxx (5) M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25) Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch https://github.com/TACC/pvOSPRay/pull/33.diff — Reply to this email directly or view it on GitHub.

GregAbram commented 8 years ago

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D. Research Engineering/Scientist Associate Texas Advanced Computing Center The University of Texas at Austin (512) 471-8196 gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee notifications@github.com<mailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end. Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram notifications@github.com<mailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

https://github.com/TACC/pvOSPRay/pull/33

Commit Summary

changes for ospray-0.9 CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs removed Glyph3DRepresentation use alignedFree rather than delete[] back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator File Changes

M CMake/FindOSPRay.cmake (118) M ParaView/CMakeLists.txt (2) M ParaView/OSPRayView.xml (10) M VTK/CMakeLists.txt (8) M VTK/vtkOSPRayCamera.cxx (2) M VTK/vtkOSPRayLight.cxx (1) M VTK/vtkOSPRayPolyDataMapper.cxx (127) M VTK/vtkOSPRayProperty.cxx (7) M VTK/vtkOSPRayRenderable.h (9) M VTK/vtkOSPRayRenderer.cxx (27) M VTK/vtkOSPRayTexture.cxx (5) M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25) Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch https://github.com/TACC/pvOSPRay/pull/33.diff — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/TACC/pvOSPRay/pull/33#issuecomment-168840033.

carsonbrownlee commented 8 years ago

Gl1 was working for me, gl2 broken due to missing depth issue. For gl1, same error without pvospray right? Perhaps it would be worth letting Utkarsh know. Carson

On Jan 5, 2016, at 9:44 AM, Greg Abram notifications@github.com wrote:

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D. Research Engineering/Scientist Associate Texas Advanced Computing Center The University of Texas at Austin (512) 471-8196 gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee notifications@github.com<mailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end. Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram notifications@github.com<mailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

https://github.com/TACC/pvOSPRay/pull/33

Commit Summary

changes for ospray-0.9 CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs removed Glyph3DRepresentation use alignedFree rather than delete[] back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator File Changes

M CMake/FindOSPRay.cmake (118) M ParaView/CMakeLists.txt (2) M ParaView/OSPRayView.xml (10) M VTK/CMakeLists.txt (8) M VTK/vtkOSPRayCamera.cxx (2) M VTK/vtkOSPRayLight.cxx (1) M VTK/vtkOSPRayPolyDataMapper.cxx (127) M VTK/vtkOSPRayProperty.cxx (7) M VTK/vtkOSPRayRenderable.h (9) M VTK/vtkOSPRayRenderer.cxx (27) M VTK/vtkOSPRayTexture.cxx (5) M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25) Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch https://github.com/TACC/pvOSPRay/pull/33.diff — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/TACC/pvOSPRay/pull/33#issuecomment-168840033.

— Reply to this email directly or view it on GitHub.

GregAbram commented 8 years ago

Thats right. I’ll ping Utkarsh.

Greg

Gregory D. Abram, Ph.D. Research Engineering/Scientist Associate Texas Advanced Computing Center The University of Texas at Austin (512) 471-8196 gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 5, 2016, at 10:46 AM, carsonbrownlee notifications@github.com<mailto:notifications@github.com> wrote:

Gl1 was working for me, gl2 broken due to missing depth issue. For gl1, same error without pvospray right? Perhaps it would be worth letting Utkarsh know. Carson

On Jan 5, 2016, at 9:44 AM, Greg Abram notifications@github.com<mailto:notifications@github.com> wrote:

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D. Research Engineering/Scientist Associate Texas Advanced Computing Center The University of Texas at Austin (512) 471-8196 gda@tacc.utexas.edumailto:gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end. Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

https://github.com/TACC/pvOSPRay/pull/33

Commit Summary

changes for ospray-0.9 CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs removed Glyph3DRepresentation use alignedFree rather than delete[] back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator File Changes

M CMake/FindOSPRay.cmake (118) M ParaView/CMakeLists.txt (2) M ParaView/OSPRayView.xml (10) M VTK/CMakeLists.txt (8) M VTK/vtkOSPRayCamera.cxx (2) M VTK/vtkOSPRayLight.cxx (1) M VTK/vtkOSPRayPolyDataMapper.cxx (127) M VTK/vtkOSPRayProperty.cxx (7) M VTK/vtkOSPRayRenderable.h (9) M VTK/vtkOSPRayRenderer.cxx (27) M VTK/vtkOSPRayTexture.cxx (5) M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25) Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch https://github.com/TACC/pvOSPRay/pull/33.diff — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/TACC/pvOSPRay/pull/33#issuecomment-168840033.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/TACC/pvOSPRay/pull/33#issuecomment-169057514.