search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

Add plugin for rapid generation of staff pages #253

Closed jarosenb closed 1 year ago

jarosenb commented 1 year ago

Overview

Adds a CMS plugin that allows staff profiles to be added by filling out a form. Headshot photos are managed through Filer.

TODO: styling/formatting on the template

Related

Changes

Testing

  1. Add a staff profile page with all fields filled out.

UI

image

Notes

wesleyboar commented 1 year ago

I had started work on UI. I will return to it.

wesleyboar commented 1 year ago

I've got two more tasks to do in #269.

wesleyboar commented 1 year ago

269 finally ready, again.

(More tasks had been added after designer review.)

wesleyboar commented 1 year ago

Design Review #2

I plan to have these tasks done by Monday, so H.P. and I can demo with an HR staff.

  1. [x] do not require Phone
  2. space between[^1][^2]
    • profile Bio only Education from "Other" fields
    • footer and profile with no Education
    • footer and profile with no Photo nor Education
  3. [x] reduce margin under headings cut by half, but not in a content-block
  4. [x] add Job Title help text; something like 'If you are a manager, enter "Manager" here.'
  5. [x] Make UT seal image bigger (or center it).

[^1]: Caused by no <p> tag in the WYSIWYG. Caused by me (https://github.com/TACC/Core-CMS/pull/574) allowing inline tags without <p> wrap.

[^2]: Moved to TUP-566.

wesleyboar commented 1 year ago

Sorry for the direct commits.[^1] I've isolated other changes[^2] into new PR:

Note Fixings space between elements is a can of worms: TUP-566.

[^1]: The direct commits "reduce margin under headings" and improve CSS comments. [^2]: Ensuring space between elements is a can of worms. I'll search for quick solution.