issues
search
TACC
/
tup-ui
React client for TACC User Portal
2
stars
0
forks
source link
Search modal for adding members to projects - UI tweaks
#259
Closed
wesleyboar
closed
1 year ago
wesleyboar
commented
1 year ago
Overview
Resolve issues form design reviews.
Related
updates #246
Changes
fixed
modal height from dynamic to static
fixed
modal scroll to be on the table
feat
: right-align add/remove column
fix
: shrink-wrap add/remove column
Testing
Open a project of which you are a PI or manager.
Open the "Add Users" (via the [+ Add Users] button).
Check bottom of modal does not have a stray border (from empty footer).
Search for a user that gives results, like Last Name: "Gonzalez".
Check modal height does not change.
Make browser window vertically short enough that it cannot fit all rows in table.
Check modal height changes (to remain 50% height of browser window).
Check table has a scrollbar.
Scroll the table.
Check table header does not scroll away.
Add a user.
Check right aligned text of "✓ Added | Remove" of the row of that user and "+ Add User" of other rows.
Check the add/remove column is only as wide as necessary to fit "✓ Added | Remove" and standard cell padding.
UI
Narrow Column
add \
remove
add user
Modal Height & Scroll
short full modal with scroll
tall full modal with scroll
tall empty modal no scroll
Overview
Resolve issues form design reviews.
Related
Changes
Testing
UI
Narrow Column
Modal Height & Scroll