search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

fix: mfa pair validation error message #296

Closed wesleyboar closed 1 year ago

wesleyboar commented 1 year ago

Overview & Changes

  1. Fix short inline errors to appear beneath input field
  2. Improve user-friendliness of MFA validation error message.
  3. Include technical error message via new pattern.

Related

Testing

  1. Be unpaired.
  2. Open http://localhost:8000/portal/mfa/sms or http://localhost:8000/portal/mfa/totp.
  3. If at /totp (QR code), then generate QR code.
  4. On either MFA method, verify gibberish token.
  5. Confirm error message is

    Your token is invalid.

UI

QR SMS
qr sms
ⓧ Include Technical Error (11aff00, reverted) > **Important** > Outdated solution. [Reason.](https://github.com/TACC/tup-ui/pull/296#pullrequestreview-1577587176) | before clicking the error | after clicking the error | | - | - | | ![Error (before click)](https://github.com/TACC/tup-ui/assets/62723358/fa41d0c1-5537-485c-837d-191899b5475a) | ![Error (after click)](https://github.com/TACC/tup-ui/assets/62723358/3b9c23d4-2c3b-43a0-bca1-59a5a8dc7b0c) | https://github.com/TACC/tup-ui/assets/62723358/06b3afea-00b0-4156-b8f3-63c139e10efb