TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

Add plugin for rapid generation of staff pages - more design tweaks #300

Closed wesleyboar closed 1 year ago

wesleyboar commented 1 year ago

Overview

Changes after Design Review № 2.

Related

Changes

  1. do not require Phone
  2. missing space between elements user error caused by developer mistake (see [1])
  3. reduce margin under headings (except in content-block) fixed in #253 at 71b3319
  4. add Job Title help text to clarify "Manager" text goes there
  5. make UT seal image bigger

Testing

  1. Save plugin instance with no phone. Confirm no error.
  2. Review help text under "Job Title".
  3. Save plugin instance with no image. Confirm UT seal is as wide as container.

UI

Before

before

https://github.com/TACC/tup-ui/assets/62723358/99f04368-bf73-4dfa-85ab-589ea59ddf0b

After

after

https://github.com/TACC/tup-ui/assets/62723358/f1d1aa49-e0a7-49c4-9c17-44c9525633ae