search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: allow smaller `<TicketCreateModal>` button #319

Closed wesleyboar closed 11 months ago

wesleyboar commented 1 year ago

Overview / Changes

  1. Allow TicketCreateModal to use different size (or type) buttons.
  2. Reduce size of [ + New Ticket ] on Dashboard.

Related

Testing

  1. Open Dashboard.
  2. Verify "+ New Ticket" button is smaller.
  3. Thus, see height of header title and button height are less different.

UI

before after
before after
wesleyboar commented 1 year ago

@jarosenb Yes, it is more complex than is needed.[^1] Adding padding (manually, I assume) ignores the purpose of having a <Button> and its size="small" prop. But I grok the secondary-small idea. Is this new solution less complex enough?

[^1]: Though still less than half as complex as my uncommitted first attempt's chaos code, which had added size prop to <TicketCreateModal>, and imported <Button>'s prop limitations (after having exported them, which was even more code). 🙂

wesleyboar commented 11 months ago

Replaced by https://github.com/TACC/tup-ui/pull/320 which will soon include a commit by @jarosenb to make it easier for other devs to grok.