TACC / tup-ui

React client for TACC User Portal

2 stars 0 forks source link

fix: tup-589, font size increase should only be for portal #321

Closed wesleyboar closed 12 months ago

wesleyboar commented 12 months ago

Overview

Portal font size update was done via TUP-CMS styles instead of TUP-UI styles. Whoops.

Related

TUP-589
fixes #312

Changes

moved portal font-size update from tup-cms to tup-ui

Testing & UI

1. CMS Main Menu Font Size

| cms | portal | | - | - | | ![cms font size value](https://github.com/TACC/tup-ui/assets/62723358/1fcd0b18-f5a5-4bed-9e46-44e4a382685e) | ![portal font size value](https://github.com/TACC/tup-ui/assets/62723358/55da5c9b-ce21-44fe-9125-6ff9a4c33de8) | ^{The font size is still visually different (by 2 pixels of height). But, that is a long-standing (forgotten) production bug **not** caused by #312.}

2. Portal Font Size is Still Bigger (copied from #312)

### 1. `

` is Bigger | before | after | | - | - | | | | ### 2. Other Font is Bigger #### `

` | before | after | | - | - | | | | #### `` | before | after | | - | - | | | | #### pill | before | after | | - | - | | | | #### `` | before | after | | - | - | | | | #### nav text — unchanged | before | after | | - | - | | | | #### nav icon | before | after | | - | - | | | | ### 3. Dashboard User News — unchanged #### Date — unchanged | before | cms | after | | - | - | - | | | | | #### Title — unchanged | before | cms | after | | - | - | - | | | | | #### Summary — unchanged | before | cms | after | | - | - | - | | | | | ### 4. No Horizontal Scrollbars https://github.com/TACC/tup-ui/assets/62723358/7f9e8684-7bac-48e3-9fdb-3b4311458804 https://github.com/TACC/tup-ui/assets/62723358/2b0de3e2-81dc-4d81-893f-f0d1d57a4bc8 https://github.com/TACC/tup-ui/assets/62723358/82272adf-4d53-4549-aaae-e95d27882e4e