chore: simplify <Button> type and size prop checks

[wesleyboar]

Overview

Simplify checks for <Button> props: type, size.

Note Now <Button> shows console errors, instead of TypeScript errors.

Warning By doing this, debugging prop errors with <Button> can be slower.

Related

• caused by https://github.com/TACC/tup-ui/pull/317
• allows simplification of https://github.com/TACC/tup-ui/pull/319
• allows simplification of https://github.com/TACC/tup-ui/pull/320

Changes

• removed unnecessary <Button> test
• changed some <Button> prop checks to be console errors

Testing

1. npx nx test core-components
2. npx nx test tup-ui
3. All tests should pass.

UI

N/A

[wesleyboar]

The prop type checking (how works before this) seems to be the best way to avoid devs making buttons wrong.

Rejected Alternatives

• this PR — ⚠️ slower debugging, less formal than prop checks
• changing/adding CSS to make problems more obvious — ⚠️ not the responsibility of CSS