search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: tup-612 isNestedHeader prop in <SectionHeader> #335

Closed wesleyboar closed 9 months ago

wesleyboar commented 10 months ago

Overview

Do not nest <header> tags.

Related

Changes

Testing

  1. Open each section.
  2. Inspect elements of the section header.
  3. Verify only one <header> tag is used for the section header.

UI

before after
Projects proj alloc - before proj alloc - after
Project project - before project - after
System sys status - before sys status - after
Unchanged | dashboard | account | tickets | | - | - | - | | ![dashboard - before](https://github.com/TACC/tup-ui/assets/62723358/298d9d3d-7310-4a0f-a866-7c5c0791a4a3) | ![mng acct - before](https://github.com/TACC/tup-ui/assets/62723358/53d27bd0-ea5a-48b1-afd0-013dac00c1b9) | ![tickets - before](https://github.com/TACC/tup-ui/assets/62723358/9fb09748-f4d0-4764-bae7-140370c9b6c8) |

Notes

Were <Section> used, this prop would not be necessary. But instead <PageLayout> and <SectionHeader> are used independently, allowing developers the freedom to make inconsistent layouts.

I welcome ideas for other solutions (to TUP-612). But, try to avoid suggestions that result in more wrapper elements than the app already (and inconsistently) suffers.

wesleyboar commented 9 months ago

Might be helpful to have same class across the board

Roight?! I proposed new ticket for solving that, ideally in exactly that way.

R-Tomas-Gonzalez commented 9 months ago

Might be helpful to have same class across the board

Roight?! I proposed new ticket for solving that, ideally in exactly that way.

Right! I agree to making a new ticket. Will approve with branch is updated.