search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: tup-463 migrate css to core #344

Closed wesleyboar closed 8 months ago

wesleyboar commented 10 months ago

Overview

Migrate CSS from here to Core-CMS and Core-Styles.

Status

Tested many times. Fixed many bugs. Ready for review.

- [x] deploy 0e84c10 — Build 134 (Nov 13, 2023 11:13:35 AM) - [x] deploy 3167014 — Build 135 (Nov 13, 2023 11:47:59 AM) - [x] bugs [TUP-646](https://jira.tacc.utexas.edu/browse/TUP-646), [TUP-649](https://jira.tacc.utexas.edu/browse/TUP-649), [TUP-650](https://jira.tacc.utexas.edu/browse/TUP-650), [TUP-654](https://jira.tacc.utexas.edu/browse/TUP-654) - [x] deploy bee6a46 — Build 136 (Nov 20, 2023 7:09:34 PM) - [x] test previous bug fixes - [x] bugs [TUP-657](https://jira.tacc.utexas.edu/browse/TUP-657), [TUP-658](https://jira.tacc.utexas.edu/browse/TUP-658), [TUP-659](https://jira.tacc.utexas.edu/browse/TUP-659), [TUP-660](https://jira.tacc.utexas.edu/browse/TUP-660) - [x] install new core-styles (and core-cms with new core-styles) - [x] deploy — Build 137 (Nov 21, 2023 6:03:53 PM) - [x] test - [x] deploy — Build 138 (Nov 22, 2023 1:12:14 PM) - [x] test (after turkey time) - [x] deploy — Nov 27 - [x] test - [x] deploy Core-CMS at a release (v4.2.0) — Build 142 (Nov 28, 2023 2:47:44 PM)

Related

Changes

Testing & UI

This is mostly moving styles and fixing bugs, so UI looks the same. But there are some differences.

See merged PRs to feat/tup-463 branch before 2023-12-01.

change screenshot
search is styled search
footer buttons less negative space footer buttons
form button is uppercase form button uppercase
"Learn more" links wrap learn more links wrap
wesleyboar commented 9 months ago

[!WARNING] MFA c-nav is broken. PR #375 is suspect because CSS module removed in favor of Core-Styles.

Update: Fixed by #379.

wesleyboar commented 8 months ago

Merging with one approval, because: