TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: tup-624: added generics/attributes to demo #345

Closed R-Tomas-Gonzalez closed 10 months ago

R-Tomas-Gonzalez commented 10 months ago

Overview

Migrate generics/attributes to core-styles

Related

Changes

https://github.com/TACC/Core-Styles/pull/244

Testing

We use data-prefix in the blog sections on the home screen and the portal screen

UI

Screenshot 2023-10-12 at 12 54 21 PM Screenshot 2023-10-12 at 12 54 10 PM

Notes

R-Tomas-Gonzalez commented 10 months ago

Please look for more instances of generics/attributes or attributes, to make sure everything related is cleaned up.

I found ~one file~ [some code] to be removed ~[which probably means another import to remove]~ [in]:

apps/tup-cms/src/taccsite_custom/tup_cms/static/tup_cms/css/for-core-styles/components/c-button.css

Update: Don't delete file (or import of it) yet. I was thinking ahead to after #343 is merged. But that is not merged yet, so c-button.css should remain. Thanks @R-Tomas-Gonzalez for catching me on this.

Resolved with commit: 0ce028f