fix: tup-639 move c-button font-weight bold to cms - Githubissues

TACC / tup-ui

React client for TACC User Portal

2 stars 0 forks source link

fix: tup-639 move c-button font-weight bold to cms #364

Closed wesleyboar closed 9 months ago

wesleyboar commented 9 months ago

Overview

Move c-button font-weight bold to CMS.

Related

TUP-639
inspired by https://github.com/TACC/Core-Styles/pull/251#discussion_r1380667528
requires https://github.com/TACC/Core-CMS/pull/740
requires https://github.com/TACC/Core-Styles/pull/253

Changes

removed c-card c-button font-weight

Testing

Setup

In Core-CMS, checkout fix/tup-617-c-button-font-weight.
In tup-ui, checkout fix/tup-617-c-button-font-weight.
In Core-CMS, install Core-Styles fix/tup-617-c-button-font-weight (steps).
In tup-ui, install Core-Styles fix/tup-617-c-button-font-weight (steps).
In Core-CMS create image and test it on tup-ui (steps).

Not in a Card

Test this change on https://www.tacc.utexas.edu/. _{See https://github.com/wesleyboar/tup-ui-migration-to-core.}
Verify "GETTING STARTED" button is bold.
Verify button has no instances of font-weight: var(--medium) applied (even if overwritten).
Verify button has letter-spacing from https://github.com/TACC/Core-CMS/pull/740/files.

In a Card

Test this change on https://www.tacc.utexas.edu/education/k-12-students/high-school-camps/gencyber/#application. _{See https://github.com/wesleyboar/tup-ui-migration-to-core.}
Verify "APPLICATION CLOSED" button is bold.
Verify button has no instances of font-weight: var(--medium) applied (even if overwritten).
Verify button has letter-spacing from https://github.com/TACC/Core-CMS/pull/740/files.

UI

Not in a Card	In a Card

wesleyboar commented 9 months ago

After #361 and merging main (7c060cf), this PR expectedly has zero changes.