search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: tup 648 do not use plain highlight class #370

Closed wesleyboar closed 10 months ago

wesleyboar commented 10 months ago

Overview

Use .u-highlight not .highlight.

Warning Merge delayed; pending https://github.com/TACC/Core-Styles/pull/261.

Important After deploy:

  1. Replace use of highlight class with u-highlight in snippet.
  2. Replace use of highlight class with u-highlight in markup.
  3. Test again.
  4. Publish
screenshot guides | | Before | After | | - | - | - | | markup | ![markup BEFORE](https://github.com/TACC/tup-ui/assets/62723358/f2ad24e6-21f0-4ceb-8425-98688a11bb3b) | ![markup AFTER](https://github.com/TACC/tup-ui/assets/62723358/b7f11284-25b7-4db8-8f6b-cd7880f37a48) | | snippet | ![snippet BEFORE](https://github.com/TACC/tup-ui/assets/62723358/731af865-4b79-416f-bbc4-e142703ed381) | ![snippet AFTER](https://github.com/TACC/tup-ui/assets/62723358/cab924d7-bff4-450b-bbd6-80552a5d3de4) |

Related

Changes

Testing

  1. Mimic changes from https://github.com/TACC/Core-Styles/pull/261.
  2. Load styles from this #370 PR.
  3. Edit markup of banner text to use u-highlight, not highlight.
  4. Verify header text is highlighted the same as before.
  5. Verify header text — on hover — is highlighted the same as before.

UI

changed markup and css, annotated screenshot
annotated screenshot
changed markup and css, mouse hover screenshot
screenshot on hover
wesleyboar commented 10 months ago

Warning Merge delayed; pending https://github.com/TACC/Core-Styles/pull/261.

R-Tomas-Gonzalez commented 10 months ago

Warning Merge delayed; pending TACC/Core-Styles#261.

Adjustments made to PR above ^

wesleyboar commented 10 months ago

Tested locally with #344's 90163f6 merged in (543cea3). Worked.