bug/tup-655 Fix footer social icon overlap

TACC / tup-ui

React client for TACC User Portal

2 stars 0 forks source link

bug/tup-655 Fix footer social icon overlap #372

Closed R-Tomas-Gonzalez closed 7 months ago

R-Tomas-Gonzalez commented 8 months ago

Overview

Quick Fix: On production site, social media icons overlap the branding icons on footer.

TUP-655

Changes

Added style to the a tag of logo branding instead of to the p tag

Testing

https://www.tacc.utexas.edu/ Scroll down to footer, expand window (if not on wide screen) and make sure icons don't overlap.

UI

before	after
	Not sure the max-height is necessary. @wesleyboar please advise.

Notes

wesleyboar commented 7 months ago

Not sure the max-height is necessary. @wesleyboar please advise.

The max-height is not necessary, but serves a purpose a preventing images from becoming too tall in edge cases. The latest footer code makes those edge cases rare.

very wide screen, sans max	very wide screen, with max