search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

fix: tup-657 icons too small / redundant cortal.icon.css import #380

Closed wesleyboar closed 10 months ago

wesleyboar commented 10 months ago

Overview

Remove redundant import of cortal.icon.css. Redundant because: 1. [Portal app imports `core-styles.portal.css`.](https://github.com/TACC/tup-ui/blob/v1.1.2/apps/tup-cms/src/apps/portal/templates/portal/assets.html#L6) 2. [`core-styles.portal.css` already imports `cortal.icon.css`.](https://github.com/TACC/Core-Styles/blob/v2.21.1/src/lib/_imports/core-styles.portal.css#L27) 3. [`Icon.tsx` uses global `icon` classes.](https://github.com/TACC/tup-ui/blob/chore/remove-unnecessary-import/libs/core-components/src/lib/Icon/Icon.tsx#L20)

It caused duplicate CSS which had greater precedence than the original.

Related

Changes

Testing

  1. Open portal.
  2. Verify icons still load (e.g. in sidebar).
  3. Verify icon size is larger than production.

UI

before after
before (prod) after (local)