TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

sub-task/tup-575 Adds in new aria-describedby link attributes #388

Closed R-Tomas-Gonzalez closed 7 months ago

R-Tomas-Gonzalez commented 7 months ago

Overview

Let's target all of the a tags that have target="_blank" and make them accessible.

Related

Changes

Testing

  1. Make sure to run npx nx build tup-cms and npx nx build tup-ui
  2. Serve both of them
  3. Add Snippet JS: New Tab | New Window to Footer-Content - Accessibility Content
  4. Find each target in the inspector. Make sure any target with "_blank" has thearia-describedby="msg-open-ext-site-new-window"` attribute

UI

Add snippet to Content
Screenshot 2023-12-08 at 11 18 08 AM
Check for aria-describedby attribute
Screenshot 2023-12-06 at 11 49 48 AM
R-Tomas-Gonzalez commented 7 months ago

Functionally, looks good. I'll test.

Until then, you may normalize the comment syntax.

  • E.g. // comment or /* comment */ (JavaScript)
  • Not // // comment nor // /** comment */ nor // /* comment */ (redundant).

Done. 448c4bc

R-Tomas-Gonzalez commented 7 months ago

072a4e7

Changes:

Screenshot 2023-12-08 at 11 06 30 AM Screenshot 2023-12-08 at 11 07 27 AM