search

TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: tup-677 css/django/vite interoperability #400

Closed wesleyboar closed 8 months ago

wesleyboar commented 9 months ago

Overview

Edit CSS so that Django and Vite do not use it unexpectedly.

Related

Pull Requests - https://github.com/TACC/tup-ui/pull/400 requires: - https://github.com/TACC/Core-Styles/pull/285 - https://github.com/TACC/Core-CMS/pull/780 requires: - https://github.com/TACC/Core-Styles/pull/285 - https://github.com/TACC/Core-CMS-Resources/pull/197

Changes

Testing

  1. Uncertain. See https://github.com/TACC/tup-ui/pull/398.
  2. Verify TextCopyField button UI and UX is unchanged.
    1. Open /portal/mfa/totp.
    2. Press the [ Click to Generate QR Code ] button.
    3. View & Use the button under "Can't scan QR code?".
  3. Verify /static/tup_cms/css/for-tup-cms/elements/mailto-link.css successfully imports its site_cms counterpart.
  4. Verify /static/site_cms/css/build/mailto-link.css has font-size: inherit (not font-size: medium).

UI

  1. https://github.com/TACC/tup-ui/assets/62723358/01d839e6-a799-4d03-aef1-aebb6b9937cb

    https://github.com/TACC/tup-ui/assets/62723358/b23a61cb-4422-4ee7-94d4-ecd2becec66f

  2. mailto-link css loads
  3. mailto-link css has font-size initial