TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

hotfix: c-feed-list must support `<p><time/></p>` #427

Closed wesleyboar closed 4 months ago

wesleyboar commented 4 months ago

Overview

In c-feed-list:

Problem

Before Editing Text Plugin Instances After Editing Text Plugin Instances
The <time> is not wrapped in a <p> tag. Nor is "See all …" link. The <time> is wrapped in a <p> tag. So is "See all …" link.
after edit beofre edit
Video https://github.com/TACC/tup-ui/assets/62723358/9fe25b2d-4f3b-4503-ab6d-dc8e50b4d695

Related

Changes

Testing

[!IMPORTANT] Fixed on prod via a snippet, so test on dev site.

  1. See home page "User Updates" section UI before this hotfix.
  2. Edit all Text blocks in:
    • /training/
      • under "Upcoming Training" don't forget the empty one that is where a "See all …" link would be
      • under "TACC Training Highlights"
    • home page
      • under "Training & Events"
  3. Make no actual change.
  4. Save each Text block. This will change the markup produced.
    • Automatically, a <p> will wrap the <time> in an event.
    • Automatically, a <p> will wrap the <a> in the "See all …" link.
  5. Verify UI of those sections has only accepted changes.*
  6. Verify UI of home page "User Updates" section does not change.*

[!IMPORTANT]

* Accepted Changes - More space between icon and "See all …" on "Training & Events" and "TACC Training Highlights". | Before | After | | - | - | | before | after | - Vertical alignment of event buttons is more center/accurate. | Before | After | | - | - | | ![old button alignment](https://github.com/TACC/tup-ui/assets/62723358/9310d750-8805-4d4c-a3b0-32b38fab6fc6) | ![new button alignment](https://github.com/TACC/tup-ui/assets/62723358/7b054c0e-21d4-431f-80e6-8c9eaaae1f48) |

UI

Before After
Home "Train… & Events" home train before home train after snippet
Home "… Updates" home user before home user after snippet
Training Page all training before all training after snippet

Notes

The "UI" screenshots were taken on Prod after adding a snippet, but they match exactly my testing on dev with the updated stylesheet. I reverted my markup changes to dev, so a reviewer can test.

wesleyboar commented 4 months ago

Within the "Overview", I've added a "Problem" section, that illustrates what is being hotfixed.