TACC / tup-ui

React client for TACC User Portal
2 stars 0 forks source link

feat: TUP-700 @tacc/core-components - use, test, fix #465

Open wesleyboar opened 1 month ago

wesleyboar commented 1 month ago

Overview

  1. Test …/core-components as @tacc/core-components in clients.
  2. Fix issues.

Status

Related

Changes

Testing

0. Package @tacc/core-components

  1. npm install --include=optional --workspace=libs/core-components
  2. Build @tacc/core-components i.e. npx nx build core-components
  3. Package @tacc/core-components (for use in local install) e.g. npm pack --workspace=libs/core-components --pack-destination=../[^1]
  4. Prepare a client to use @tacc/core-components package. I already did this in each client's `feat/TUP-700-core-components-node-pkg--use-pkg` branch: 1. Delete `react/src/core-components` **and** `react/src/core-wrappers`. 2. Find code references to `core-components` **and** `core-wrappers`. 3. Replace `import`s of `core-components` **and** `core-wrappers` with `@tacc/core-components`. 5. Remove non-`import` references to `core-components` **and** `core-wrappers`.

1.A. Client: TACC-Cloud/Hazmapper

  1. Set up https://github.com/TACC-Cloud/hazmapper.
  2. Verify app renders with its core-components.
  3. Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
  4. npm install --save ../../tacc-core-components-0.0.1.tgz[^1]
  5. Verify no errors.
  6. ➡️ Verify app works with installed core-components.

1.B. Client: TACC/Core-Portal

  1. ➡️ Set up https://github.com/TACC/Core-Portal.
  2. Verify app renders with its core-components.
  3. ❌ Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
  4. npm install --save ../../tacc-core-components-0.0.1.tgz[^1]
  5. Verify no errors.
  6. Verify app works with installed core-components.

1.C. Client: TACC/tup-ui

  1. ➡️ Set up 2nd clone of https://github.com/TACC/tup-ui.
  2. Verify app renders with its core-components.
  3. ❌ Checkout feat/TUP-700-core-components-node-pkg--use-pkg.
  4. npm install --save ../../tacc-core-components-0.0.1.tgz[^1]
  5. Verify no errors.
  6. Verify app works with installed core-components.

[^1]: Tester should check paths to @tacc/core-components: to where to package, from where to install.

UI

Notes

[!WARNING] Installing on client TACC-Cloud/Hazmapper causes warnings about Vite version because client's Vite version v3.0.7 is too old to be used as a peer dependency by a dev dependency of an optional dependency of @tacc/core-components.