TAGC / dotnet-setversion

.NET Core CLI tool to update the version information in .NET Core *.csproj files
MIT License
75 stars 16 forks source link

Fixed crash when folders contain msbuild-style projects. #14

Closed sharpninja closed 5 years ago

sharpninja commented 5 years ago

Rebased as requested.

TAGC commented 5 years ago

Cheers mate.

I'd prefer for now if it handled msbuild style projects in the following way:

I've added failing integration tests in the commit I pushed to your develop branch. I'd appreciate if you did the following:

I noticed that the build succeeded even though my integration tests failed, so I'll be pushing some changes to this repo's develop branch to fix my AppVeyor config so they fail. You'll need to rebase on those changes. (Edit) I've done this, no worries.

sharpninja commented 5 years ago

It would make sense to go ahead and extend functionality to including updating AssemblyInfo.cs and .nuspec files.

TAGC commented 5 years ago

I guess, but that would require more work. Going down that route, I'd first like to make dotnet-setversion gracefully fail for (or skip) old-style projects, release that as v2.0.1, then after that functionality to bump versions in other types of files could be implemented as a minor-level release.

TAGC commented 5 years ago

I'm going to close this for now, but let me know if you want it re-opened.