search

TAGC / dotnet-setversion

.NET Core CLI tool to update the version information in .NET Core *.csproj files
MIT License
75 stars 16 forks source link

Doesn't work for dotnetcore 2.0 #3

Closed pms1969 closed 7 years ago

pms1969 commented 7 years ago

If i run this in the microsoft/dotnet:2.0-sdk docker image, I get the following error:

root@79f59544b01b:~/app/implementation/Configuration# dotnet setversion 0.0.1
It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '1.0.4' was not found.
  - Check application dependencies and target a framework version installed at:
      /
  - Alternatively, install the framework version '1.0.4'.
root@79f59544b01b:~/app/implementation/Configuration#

Building it and targeting netcore2.0 app and packaging it and using that version works, so it's just a matter of targeting both, or possibly even copying the files into a netcore2.0 target platform in the nuget.

TAGC commented 7 years ago

I've reproduced this issue in a Docker container based on microsoft/dotnet:2.0-sdk. I've also published a pre-release version that appears to resolve this issue.

Can you reference the pre-release package using <DotNetCliToolReference Include="dotnet-setversion" Version="1.0.1-bugfix-3-0001" /> in your project and confirm the fix? If it works, I'll publish it as a stable release (v1.0.1).

pms1969 commented 7 years ago

sorry, haven't forgotten you. been stuck with a production problem for the last few days. still ongoing. I'll confirm as soon as I can.

pms1969 commented 7 years ago

confirmed. sorry for the delay.

TAGC commented 7 years ago

Cool, I'll publish the next release imminently.