Use CMake targets - Githubissues

TALP-UPC / FreeLing

FreeLing project source code

Other

252 stars 96 forks source link

Open jgsogo opened 4 years ago

jgsogo commented 4 years ago

Using CMake targets, information about include directories, libraries, link flags,... is contained in the target and added to the dependencies.

One doubt I have:

Not sure if Boost_LIBRARIES variable already contains the target. If not, we should use Boost::program_options Boost::regex Boost:serialization (or the required targets for each library).

As the other PR, I hope this is not breaking existing builds, if so, let me know how to reproduce them and I will work on these changes.

lluisp commented 4 years ago

CMakeLists for libdynet are mainly those from the original project. I'd prefer to keep them as they are (or to update them from source if needed).

Can you post a PR withouth those changes?