TAMULib / CatalogService

A service for interfacing with Library Catalogs
MIT License
0 stars 1 forks source link

Issue 194: Multiple items from the same bib record checked out. #174

Closed kaladay closed 2 years ago

kaladay commented 2 years ago

resolves TAMULib/MyLibraryService#194

The existing logic uses the InstanceId when instead it should use the ItemId. Switch to the ItemId to ensure each item works.

This addresses the backend portion of the referenced issue. Changes to the front-end are suggested such that each item can be uniquely identified (Such as "Barcode" or "Effective Call Number").

There are some additional performance considerations as well. The current design fetches from the patron edge and then performs okapi requests to loans. If we have to access Loans directly rather than through the edge module, then why not do so? Query can be done using something as simple as:

"(userId==%s and status.name==Open) sortBy %s"

(Taken from the edge patron code.)

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1742648168


Totals Coverage Status
Change from base Build 1741861929: 0.0%
Covered Lines: 731
Relevant Lines: 1185

💛 - Coveralls