TAMULib / DSpace

(Official) The DSpace digital asset management system that powers your Institutional Repository
https://wiki.duraspace.org/display/DSDOC4x/Introduction
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

[DSpace 7 Upgrade] Reimplement describe step for submission workflow customizations #219

Closed wwelling closed 8 months ago

wwelling commented 10 months ago

~Blocks https://github.com/TAMULib/DSpace/issues/202~

org.dspace.app.xmlui.aspect.submission.submit.DescribeStep

May need to be transferred to DSpace repository or another issue be created in DSpace repository.

Dbreck-TAMU commented 10 months ago

is in XMLUI package (was removed in dspace 7). -- Want to maintain feature parity.

Could create a custom UI override.

Add documentation regarding to this process. Could help with issue #49.

Could have William/James walk through the process and 49 to follow as it follows the same process but for a different customization.

wwelling commented 9 months ago

Here is the DescribeStep in 7:

https://github.com/TAMULib/DSpace/blob/tamu-dspace-7_x/dspace-server-webapp/src/main/java/org/dspace/app/rest/submit/step/DescribeStep.java

Here is the DescribeStep in 6:

https://github.com/TAMULib/DSpace/blob/tamu-dspace-6.3/dspace-api/src/main/java/org/dspace/submit/step/DescribeStep.java

https://github.com/TAMULib/DSpace/blob/tamu-dspace-6.3/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/DescribeStep.java

Here is the TAMU Customized DescribeStep in 6:

https://github.com/TAMULib/DSpace/blob/tamu-dspace-6.3/dspace/modules/additions/src/main/java/org/dspace/submit/step/DescribeStep.java

https://github.com/TAMULib/DSpace/blob/tamu-dspace-6.3/dspace/modules/xmlui/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/DescribeStep.java

wwelling commented 9 months ago

The detailed_name custom field of the DescribeStep customization has been disabled from the input-forms.xml.

I have confirmed that this customization is no longer in use on OAKTrust or dspacepre1 for the applicable form-map collections.

If enabled we would see Enter the names of the authors of this item. For TAMU Faculty, Staff, and Students please use TAMU email address (@tamu.edu) as the Authors input field.

<name-map collection-handle="1969.1/93296" form-name="facultyPub"/>

Image

Image

<name-map collection-handle="1969.1/187506" form-name="facultyPub"/>

Image

Image

wwelling commented 9 months ago

@jcreel do we require bringing over the Java processing code behind the detailed_name custom field for DSpace 7 having available for submission input form?

wwelling commented 8 months ago

Upon further investigation, without the need for the detailed_name step there is no Java code customizations necessary.

https://raw.githubusercontent.com/TAMULib/DSpace/tamu-dspace-6.3/dspace-api/src/main/java/org/dspace/submit/step/DescribeStep.java

compared with

https://raw.githubusercontent.com/TAMULib/DSpace/tamu-dspace-6.3/dspace/modules/additions/src/main/java/org/dspace/submit/step/DescribeStep.java

and

https://raw.githubusercontent.com/TAMULib/DSpace/tamu-dspace-6.3/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/DescribeStep.java

compared with

https://raw.githubusercontent.com/TAMULib/DSpace/tamu-dspace-6.3/dspace/modules/xmlui/src/main/java/org/dspace/app/xmlui/aspect/submission/submit/DescribeStep.java

has no additional Java code customizations.

wwelling commented 8 months ago

Customizations for this step will be included with #202.