TAMULib / LibraryServiceStatusSystemUI

MIT License

0 stars 0 forks source link

Fix sticky footer #228

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

Add 100% height to html and body. Fixes sticky footer.

Fixes #225

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Deployed to dev and verified.

https://labs.library.tamu.edu/status/

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

ghost commented 2 years ago

What is wrong with 100% height in html and body?

It will in most all cases have no effect. Two cases it could have an effect; 1 is with a wonky js driven footer design, 2 is when a app is defining is html height specifically and not using entire view port.

With that said, is not relevant in the app as this is the solution with our previous sticky footer.