search

TAMULib / SAGE

Search Aggregation Engine
MIT License
6 stars 3 forks source link

Authentication URL is not working. #465

Open kaladay opened 1 year ago

kaladay commented 1 year ago

Describe the bug When using the URL https://labs.library.tamu.edu/authfix, the authentication does not fully complete and returns an error. This then causes a separate problem identified and solved in https://github.com/TAMULib/Weaver-UI-Core/pull/218.

This is either a bug in the server and not something solvable by code or a bug in the processing code. Determine where the problem is and go from there.

To Reproduce Steps to reproduce the behavior:

  1. Set AUTH_SERVICE_URL=https://labs.library.tamu.edu/authfix on a project, such as SAGE.
  2. Start docker.
  3. Attempt to login.
  4. See error

Expected behavior If the error is valid, then do nothing and the problem needs to be sovled on the server providing the service. If the error is invalid, then there should be no error.

jcreel commented 1 year ago

Check configuration to ensure we are pointing at the new auth service.

ghost commented 1 year ago

Default for running locally is up to date: https://github.com/TAMULib/SAGE/blob/main/.wvr/build-config.js#L40

Default for running using docker compose is up to date: https://github.com/TAMULib/SAGE/blob/main/example.env#L28

Default for build docker image will use an auth URL without specifying version in path: https://github.com/TAMULib/SAGE/blob/main/Dockerfile#L98

I think this is all acceptable and the error indicated above when unable to reach a valid auth service is appropriate. It may be that the frontend error could be more informative, and another issue may be necessary.

This issue is resolved by DevOps using appropriate auth URL to deploy.

kaladay commented 1 year ago

You missed a spot:

The authfix there needs to be updated.

ghost commented 1 year ago

@kaladay good catch. As not functional, should still be updated. Will do global search next time. ;)