Issue 502: Angularjs $location.search is not safe to use when passing '#'.

[kaladay]

Description

This is the solution created while investigating the spike #492.

This addresses the problem by replacing the # (U+0023) character with %23 for relevant situations (properties in the search).

This needs to be tested for regressions, specifically checking for data in facets and filters that have the # (U+0023) character.

Fixes #502

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [X] Manual
• [X] Front-end and Back-end tests run via mvn clean test.

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my code
• [x] My changes generate no new warnings
• [x] New and existing unit tests pass locally with my changes

[coveralls]

Coverage: 45.252% (+0.04%) from 45.217% when pulling 47168a4336ed5d44bdfd3404de5451d1f49f19f7 on 502-location_search_unsafe into b9bca09787babe73b5070fe572bd524e45b59adf on staging.