TAMULib / SAGE

Search Aggregation Engine

MIT License

6 stars 2 forks source link

Issue 498: Always set facet min count to 1. #521

Closed kaladay closed 1 year ago

kaladay commented 1 year ago

Description

This ensures matches of 0 never appear in the facets. The SolrQuery class provides a handy setFacetMinCount() method to easily utilize this functionality.

Fixes #498

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Manually.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

coveralls commented 1 year ago

Coverage: 45.844% (-0.03%) from 45.876% when pulling 418ebda6b620860a5ac09b008ede68040fc55eaf on 498-facet_count-avoid_zero into b45e8cc2d657bfbb9506f04b1285267a79d6b851 on staging.