search

TAMULib / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
http://vireoetd.org/vireo/
1 stars 0 forks source link

In student view of submission workflow the button descriptions at the top don’t match the actual fields being displayed. #59

Open devangm opened 4 months ago

devangm commented 4 months ago
kaladay commented 4 months ago

This is by design.

The video shows an existing submission. Because of the revisioning, existing submissions will not change when the button descriptions are changed.

Try to confirm behavior by creating a new submission after changing the button descriptions.

Edit: (From The video) The order on the admin submission list may be different from the student submission itself for existing submission but the actual contents of the submission on the student submission form is not consistent with the button name. The video shows a bug. New submissions need to also be checked to see if they are consistent.

kaladay commented 4 months ago

I am unable to reproduce the problem. Steps to reproduce the state will be necessary in order to diagnose.

Upgrading to the latest version of Vireo may also solve the problem.

kaladay commented 4 months ago

I have been able to reproduce the situation by doing the following:

  1. As an ADMIN, change the name of the License Agreement (original) workflow to File Upload (changed).
  2. As an ADMIN, change the name of the File Upload (original) to License Agreement (changed).
  3. Create a workflow as a STUDENT for that Organization as a STUDENT, ADMIN, etc...
  4. As an ADMIN, change the File Upload (changed) back to the original License Agreement (original).
  5. As an ADMIN, change the name of the License Agreement (changed) back to the File Upload (original).

The fields are not changed during this process and only the names of the workflow are swapped. This results in having a name conflicting with the workflow name (the workflow name is the "button description").

The Submissions in Vireo are versioned. This means that buttons displayed represent the organizational structure at the time of the creation of the Submission. Sub-sequent edits to the Organization will not be reflected in any already existing Submissions.

kaladay commented 4 months ago

During data migrations, we were able to observe that the migration script were setting the order wrong.

While the case described above does reproduce the problem, it is more or less believed that this a problem regarding the migration process and not through some direct manipulation of the structure.

The following is the SQL script used to fix the data immediately after migration (before the site gets used as this SQL assumes the structure of the data).


update submission_workflow_step set name = 'Personal Information' where id = 1;
update submission_workflow_step set instructions = '<h4>Instructions:</h4><p>Please verify all of your personal information. Some of the information has been provided by your school; if this information is in error, you will need to correct it through the appropriate office at your school.</p><p>Required fields are indicated with an asterisk.</p>' where id = 1;

update submission_workflow_step set name = 'License Agreement' where id = 2;
update submission_workflow_step set instructions = '' where id = 2;

update submission_workflow_step set name = 'Document Information' where id = 3;
update submission_workflow_step set instructions = '<h4>Instructions:</h4><p>Describe your thesis or dissertation. Please make sure that the information entered below matches the information contained in your document.</p>' where id = 3;

update submission_workflow_step set name = 'File Upload' where id = 4;
update submission_workflow_step set instructions = '<h4>Instructions:</h4><p>In this step you will upload your thesis or dissertation to the server. Optionally, you may upload additional supplementary files that will be available along with your document after publication.</p>' where id = 4;