search

TAMULib / Vireo

Vireo is a turnkey Electronic Thesis and Dissertation (ETD) Management System.
http://vireoetd.org/vireo/
1 stars 0 forks source link

Duplicate options for Major and ORCID in disable column section #82

Open devangm opened 1 month ago

devangm commented 1 month ago

To Reproduce Steps to reproduce the behavior:

Go to 'admin/list' Click on 'Customize columns' Scroll down in the Disabled Columns section See duplicates options for Major and ORCID

Image

wwelling commented 1 month ago

The SubmissionListColumn entity table has a combined unique constraint of "title", "predicate", "input_type_id".

There are two issues:

  1. the modals for selecting submission list columns or custom filters has unidentifiable duplicate titles
  2. the multi-column sort in the admin submission list view has a bug as it is using submission column title as a unique property

A simple solution would be to make title a unique constraint. This would correct all known bugs regarding.

A more versatile solution would be to provide the predicate in the label for the submission list column such as ORCID (dc.creator.orcid). This would require fixing the bug in the multi-column sort to utilize the combined label for uniqueness. Would still have edge cases to where title and predicate are unique with a different input_type_id.